Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add missing GOCACHE and GOPATH in release worflow #6192

Merged
merged 1 commit into from
Jun 12, 2024

Conversation

pmalek
Copy link
Member

@pmalek pmalek commented Jun 12, 2024

What this PR does / why we need it:

Which issue this PR fixes:

Special notes for your reviewer:

PR Readiness Checklist:

Complete these before marking the PR as ready to review:

  • the CHANGELOG.md release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR

@pmalek pmalek added the area/ci label Jun 12, 2024
@pmalek pmalek added this to the KIC v3.2.x milestone Jun 12, 2024
@pmalek pmalek self-assigned this Jun 12, 2024
@pmalek pmalek requested a review from a team as a code owner June 12, 2024 10:27
@pmalek pmalek changed the base branch from release/3.2.x to main June 12, 2024 10:29
@randmonkey randmonkey enabled auto-merge (squash) June 12, 2024 10:31
Copy link

codecov bot commented Jun 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.5%. Comparing base (6cf7279) to head (a509ad6).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##            main   #6192     +/-   ##
=======================================
- Coverage   73.6%   73.5%   -0.1%     
=======================================
  Files        200     200             
  Lines      19887   19887             
=======================================
- Hits       14637   14623     -14     
- Misses      4263    4271      +8     
- Partials     987     993      +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@czeslavo
Copy link
Contributor

CodeQL wasn't run. Probably that's the same case I had before in #6190 - apparently, changing a base branch doesn't trigger workflows for the new base branch.

Closing to reopen.

@czeslavo czeslavo closed this Jun 12, 2024
auto-merge was automatically disabled June 12, 2024 10:49

Pull request was closed

@czeslavo czeslavo reopened this Jun 12, 2024
@czeslavo czeslavo enabled auto-merge (squash) June 12, 2024 10:55
@czeslavo czeslavo merged commit b3affa1 into main Jun 12, 2024
95 checks passed
@czeslavo czeslavo deleted the fix-release-workflow branch June 12, 2024 11:09
czeslavo added a commit that referenced this pull request Jun 12, 2024
* chore(release): prepare 3.2 release (#6190)

* ci: add missing GOCACHE and GOPATH in release worflow (#6192)

* chore(ci): add mise install step to conformance tests report (#6194)

---------

Co-authored-by: Patryk Małek <patryk.malek@konghq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants