Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert dumpDiag to use kind export logs #591

Merged
merged 4 commits into from
Apr 25, 2023
Merged

Commits on Apr 24, 2023

  1. Convert dumpDiag to use kind export logs

    Today in KTF we manually step through all the pods/objects in the
    cluster to get debug information. KIND now supports simply
    running `kind export logs` which does a better job of giving us
    a cluster debug overview. Switch the DumpDiagnostics function to
    use this command for cluster log dumping instead.
    
    Intentionally leave the logic which allows each addon to write their own
    specific cleanup functionality.
    
    Also continue to export the `kubectl_describe_all.txt` and `kubectl_get_all.yaml`
    files for all cluster types.
    
    Signed-off-by: Andrew Stoycos <astoycos@redhat.com>
    astoycos committed Apr 24, 2023
    Configuration menu
    Copy the full SHA
    19aebce View commit details
    Browse the repository at this point in the history
  2. Add new Int test and update old one

    Add new integration test for using `kind export logs` in DumpDiagnostics.
    Update old addon test to use the new filepath for pod logs.
    
    Signed-off-by: Andrew Stoycos <astoycos@redhat.com>
    astoycos committed Apr 24, 2023
    Configuration menu
    Copy the full SHA
    53c6909 View commit details
    Browse the repository at this point in the history
  3. Respond to review

    Add godoc comment to DumpAllDescribeAll function.
    
    use t.cleanup instead of defer.
    
    Signed-off-by: Andrew Stoycos <astoycos@redhat.com>
    astoycos committed Apr 24, 2023
    Configuration menu
    Copy the full SHA
    3e1671c View commit details
    Browse the repository at this point in the history

Commits on Apr 25, 2023

  1. Standardize function Signature

    Standardize function signatures for all cluster diagnostics functions.
    
    Standardize name of diagnostic output directory from a mixture of "output"
    and "outDir" to just "outdir".
    
    Signed-off-by: Andrew Stoycos <astoycos@redhat.com>
    astoycos committed Apr 25, 2023
    Configuration menu
    Copy the full SHA
    ef75273 View commit details
    Browse the repository at this point in the history