fix decoding of multipart data parts containing control chars #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 28, 2017
hishamhm
reviewed
Nov 28, 2017
src/multipart.lua
Outdated
| done = true | ||
| end | ||
|
|
||
| if line ~= "" then |
There was a problem hiding this comment.
I'm not sure if I'm following this correctly, but what happens if you have a blank line split by \r\n inside one of the body parts? (ie, a blank line inside the "part value", which should be consumed in line 106)
Or is this not allowed by the multipart encoding standard, and if I send a DOS-formatted file I need to use Base64?
bungle
force-pushed
the
fix/control-chars-issues
branch
from
b5dbdb6
to
918c84f
Compare
bungle
force-pushed
the
fix/control-chars-issues
branch
from
918c84f
to
7ae8852
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my try to fix some issues with control chars, without rewriting the whole library.
It might fix issues reported here:
Kong/kong#3024
Kong/kong#2981