fix(sts): fix sts regional endpoint injection under several cases #123
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the STS regional injection logic under the following cases:
AWS_STS_REGIONAL_ENDPOINTS
isregional
, theservice.signingRegion
must be the same as the current environment's region, instead of theglobalSSL
'sus-east-1
region defined in the global region rule. This ensures that the API request sent to the regional STS endpoint has the correct signature.AWS_STS_REGIONAL_ENDPOINTS
isregional
and user defines the same regional STS domain(for example,sts.us-east-2.amazonaws.com
), ensures that the region is not being injected again inside the regional STS domain.This PR also adds unit tests to ensure the region is defined correctly in the signed request and the endpoint is also expected under several combinations of
region
,AWS_STS_REGIONAL_ENDPOINTS
and user-definedendpoint
config.KAG-5021