[merge] feat(wasmtime) new 'cache_config' directive for compilation cache #540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds support for `wasmtime { cache_config <config.toml>; }`, which
enables disk caching of ahead-of-time compilation of `.wasm` files.
This should alleviate noticeable CPU spikes when starting up workers using
Wasmtime and Wasm modules larger than a few megabytes.
Signed-off-by: Thibault Charbonnier <thibaultcha@me.com>
thibaultcha
changed the title
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #540 +/- ##
===================================================
- Coverage 90.06471% 90.05848% -0.00624%
===================================================
Files 47 47
Lines 10045 10089 +44
===================================================
+ Hits 9047 9086 +39
- Misses 998 1003 +5
... and 2 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more. |
flrgh
added a commit
to Kong/kong
that referenced
this pull request
May 23, 2024
This adds support for Wasmtime's module caching. See also: * Kong/ngx_wasm_module#540 * https://github.com/Kong/ngx_wasm_module/blob/b19d405403ca6765c548e571010aea3af1accaea/docs/DIRECTIVES.md?plain=1#L136-L149 * https://docs.wasmtime.dev/cli-cache.html
flrgh
added a commit
to Kong/kong
that referenced
this pull request
Jun 3, 2024
This adds support for Wasmtime's module caching. See also: * Kong/ngx_wasm_module#540 * https://github.com/Kong/ngx_wasm_module/blob/b19d405403ca6765c548e571010aea3af1accaea/docs/DIRECTIVES.md?plain=1#L136-L149 * https://docs.wasmtime.dev/cli-cache.html
flrgh
added a commit
to Kong/kong
that referenced
this pull request
Jun 5, 2024
* feat(wasm): add support for wasmtime cache This adds support for Wasmtime's module caching. See also: * Kong/ngx_wasm_module#540 * https://github.com/Kong/ngx_wasm_module/blob/b19d405403ca6765c548e571010aea3af1accaea/docs/DIRECTIVES.md?plain=1#L136-L149 * https://docs.wasmtime.dev/cli-cache.html * tests(wasm): add start/restart test for wasmtime cache
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.