Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for custom ciphers and protocols for https requests #381

Merged
merged 4 commits into from
Nov 4, 2020
Merged

Support for custom ciphers and protocols for https requests #381

merged 4 commits into from
Nov 4, 2020

Conversation

Hakky54
Copy link
Contributor

@Hakky54 Hakky54 commented Nov 2, 2020

This pull request is an implementation for the following feature request: #380

Usage would be for example:

Unirest.config()
    .sslContext(sslContext)
    .protocols("TLSv1.2")
    .ciphers("TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384");

This will force your client to communicate over TLSv1.2 and TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 with the server or else it will fail. This setup will also prevent your client to communicate with older protocols such as TLSv1.1 and TLSv1

Copy link
Collaborator

@ryber ryber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. I have a couple other things to work into a release, I'll probably cut it this weekend

@Hakky54
Copy link
Contributor Author

Hakky54 commented Nov 3, 2020

Thank you very much!

@ryber
Copy link
Collaborator

ryber commented Nov 3, 2020

@Hakky54 there was an issue with the GitHub Actions setup for PRs would you mind rebasing your branch with master (or merge master, either way)

@Hakky54
Copy link
Contributor Author

Hakky54 commented Nov 3, 2020

I just merged your master branch with mine master branch and pushed the changes. Please let me know if something else needs to be done

@ryber ryber merged commit e71dd10 into Kong:main Nov 4, 2020
@ryber ryber added this to the 3.11.04 milestone Nov 8, 2020
@ryber
Copy link
Collaborator

ryber commented Nov 8, 2020

This is in 3.11.04

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants