Skip to content

Commit 42a8b96

Browse files
authored
Deprecate getSofZmanShmaFixedLocal() and
getSofZmanTfilaFixedLocal() Detailed deprecation comments are in the code.
1 parent 98818d2 commit 42a8b96

File tree

1 file changed

+38
-5
lines changed

1 file changed

+38
-5
lines changed

src/main/java/com/kosherjava/zmanim/ComplexZmanimCalendar.java

+38-5
Original file line numberDiff line numberDiff line change
@@ -2829,25 +2829,58 @@ public Date getFixedLocalChatzos() {
28292829

28302830
/**
28312831
* A method that returns the latest <em>zman krias shema</em> (time to recite Shema in the morning) calculated as 3
2832-
* hours before {@link #getFixedLocalChatzos()}.
2833-
*
2834-
* @return the <code>Date</code> of the latest <em>zman krias shema</em> calculated as 3 hours before
2835-
* {@link #getFixedLocalChatzos()}..
2832+
* clock hours before {@link #getFixedLocalChatzos()}. Note that there are opinions brought down in Yisrael Vehazmanim
2833+
* <a href="https://hebrewbooks.org/pdfpager.aspx?req=9765&st=&pgnum=85">page 57</a> and Rav Yitzchal Silber's <a href=
2834+
* "https://www.worldcat.org/oclc/811253716">Sha'aos Shavos Balalacha</a> that this calculation is a mistake and regular
2835+
* <em>chatzos</em> shoud be used for clock-hour calculations as opposed to fixed local <em>chatzos</em>. According to
2836+
* these opinions it should be 3 clock hours before regular <em>chatzos</em> as calculated in {@link
2837+
* #getSofZmanShma3HoursBeforeChatzos()}.
2838+
*
2839+
* @return the <code>Date</code> of the latest <em>zman krias shema</em> calculated as 3 clock hours before
2840+
* {@link #getFixedLocalChatzos()}.
28362841
* @see #getFixedLocalChatzos()
2842+
* @see #getSofZmanShma3HoursBeforeChatzos()
28372843
* @see #getSofZmanTfilaFixedLocal()
2844+
*
2845+
* @deprecated This method of calculating <em>sof zman Shma</em> is considered a mistaken understanding of the proper
2846+
* calculation of this <em>zman</em> in the opinion of Rav Yitzchal Silber's <a href=
2847+
* "https://www.worldcat.org/oclc/811253716">Sha'aos Shavos Balalacha</a>. On pages 316-318 he discusses Rav Yisrael
2848+
* Harfenes's calculations and points to his seeming agreement that using fixed local <em>chatzos</em> as the focal
2849+
* point is problematic. See Yisrael Vehazmanim <a href=
2850+
* "https://hebrewbooks.org/pdfpager.aspx?req=9765&st=&pgnum=85">page 57</a>. While the Yisrael Vehazmanim mentions
2851+
* this issue in vol. 1, it was not corrected in the calculations in vol. 3 and other parts of the <em>sefer</em>.
2852+
* A competent rabbinical authority should be consulted before using this <em>zman</em>. Instead, the use of {@link
2853+
* #getSofZmanShma3HoursBeforeChatzos()} should be used to calculate <em>sof zman Tfila</em> using using 3 fixed
2854+
* clock hours.
28382855
*/
2856+
@Deprecated
28392857
public Date getSofZmanShmaFixedLocal() {
28402858
return getTimeOffset(getFixedLocalChatzos(), -180 * MINUTE_MILLIS);
28412859
}
28422860

28432861
/**
28442862
* This method returns the latest <em>zman tfila</em> (time to recite the morning prayers) calculated as 2 hours
2845-
* before {@link #getFixedLocalChatzos()}.
2863+
* before {@link #getFixedLocalChatzos()}. See the documentation on {@link #getSofZmanShmaFixedLocal()} showing
2864+
* differeing opinions on how the <em>zman</em> is calculated. According to many opinions {@link
2865+
* #getSofZmanTfila2HoursBeforeChatzos()} should be used as opposed to this <em>zman</em>.
28462866
*
28472867
* @return the <code>Date</code> of the latest <em>zman tfila</em>.
28482868
* @see #getFixedLocalChatzos()
28492869
* @see #getSofZmanShmaFixedLocal()
2870+
* @see #getSofZmanTfila2HoursBeforeChatzos()
2871+
*
2872+
* @deprecated This method of calculating <em>sof zman Tfila</em> is considered a mistaken understanding of the proper
2873+
* calculation of this <em>zman</em> in the opinion of Rav Yitzchal Silber's <a href=
2874+
* "https://www.worldcat.org/oclc/811253716">Sha'aos Shavos Balalacha</a>. On pages 316-318 he discusses Rav Yisrael
2875+
* Harfenes's calculations and points to his seeming agreement that using fixed local <em>chatzos</em> as the focal
2876+
* point is problematic. See Yisrael Vehazmanim <a href=
2877+
* "https://hebrewbooks.org/pdfpager.aspx?req=9765&st=&pgnum=85">page 57</a>. While the Yisrael Vehazmanim mentions
2878+
* this issue in vol. 1, it was not corrected in the calculations in vol. 3 and other parts of the <em>sefer</em>.
2879+
* A competent rabbinical authority should be consulted before using this <em>zman</em>. Instead, the use of {@link
2880+
* #getSofZmanTfila2HoursBeforeChatzos()} should be used to calculate <em>sof zman Tfila</em> using using 2 fixed
2881+
* clock hours.
28502882
*/
2883+
@Deprecated
28512884
public Date getSofZmanTfilaFixedLocal() {
28522885
return getTimeOffset(getFixedLocalChatzos(), -120 * MINUTE_MILLIS);
28532886
}

0 commit comments

Comments
 (0)