fix yerushalmi yomi class #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
P.S. sorry for the blank spaces. I copied over the whole class a few times while figuring out how to commit a proper PR. |
elijulian
reviewed
Nov 26, 2022
src/main/java/com/kosherjava/zmanim/hebrewcalendar/YerushalmiYomiCalculator.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So... a little background as to why I want to suggest this fix. I was using the Yerushalmi Calculator in my zmanim app and I noticed that it returned masechta nidda and null for the daf on tisha b'av. Same is true for Yom kippur.
No where in the javadoc does it mention this, only in the code. I had to figure this out the hard way.
In this PR, I suggest a few changes to the javadoc to make it more clear to people to check for edge cases/nulls.
And I don't know why the author decided to return a new Daf(39, 0) instead of just null. That object will return null on the getDaf() method and it is not clear why in the Daf class.
Let me know what you think about this issue.