Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Icon if player hasn't Emotecraft mod #459

Open
YoungSoulluoS opened this issue Feb 13, 2024 · 13 comments
Open

[Enhancement] Icon if player hasn't Emotecraft mod #459

YoungSoulluoS opened this issue Feb 13, 2024 · 13 comments

Comments

@YoungSoulluoS
Copy link

Thank you for good mod!

For example, the way PlasmoVoice does it if player hasn't mod.
image

@DearFox
Copy link
Contributor

DearFox commented Feb 22, 2024

Perhaps as an additional setting on the server and client - it would be nice.
But I think on the client side I would prefer it to be disabled by default

@YoungSoulluoS
Copy link
Author

Made the code on the client side, but haven't decided to start working on the server yet...

Variants for this.
I borrowed the colors from the Plasmovoice mod so there would be visual compatibility.
image

@DearFox
Copy link
Contributor

DearFox commented Mar 18, 2024

Made the code on the client side, but haven't decided to start working on the server yet...

Variants for this. I borrowed the colors from the Plasmovoice mod so there would be visual compatibility. image

Why is the last icon needed?
I think the icons themselves still need to be worked on and thought about how they should look in order to be as logical and understandable as possible.

@DearFox
Copy link
Contributor

DearFox commented Mar 18, 2024

I also think that the icon for EmoteCraft should be in the EmoteCraft style. You know, to be separate from other people's icons.

@KosmX
Copy link
Owner

KosmX commented Mar 18, 2024

I don't know if there is any possible way to display any custom icon on a non modded client.

@DearFox
Copy link
Contributor

DearFox commented Mar 18, 2024

I thought we were talking about a new feature of the mod as a whole and not a server feature

@dima-dencep
Copy link
Contributor

dima-dencep commented Mar 18, 2024

Implementing this icon would likely require intervention on the server
The client doesn't know who has the mod installed until the player plays the animation

I don't support this feature, it seems cumbersome and unnecessary for emotecraft

@DearFox
Copy link
Contributor

DearFox commented Mar 18, 2024

Implementing this icon would likely require intervention on the server The client doesn't know who has the mod installed until the player plays the animation

I don't support this feature, it seems cumbersome and unnecessary for emotecraft

Well, I don’t think that a package with an array of players and true - if there is a mod or false if there is no mod - is cumbersome.
This is an offer to improve the quality of life. I don't think it should be enabled by default, but it's a really useful feature.

@dima-dencep
Copy link
Contributor

I don't want other players to see if I have a mod or not

@DearFox
Copy link
Contributor

DearFox commented Mar 18, 2024

I don't want other players to see if I have a mod or not

Therefore, I believe that such a setting should be on the server side, the ability to turn it on or off.
Also, for greater privacy, it would be nice to receive information whether the player is using a mod or not - directly in the player’s rendering area.

@dima-dencep
Copy link
Contributor

should be on the server side

If it's server-side, the player won't be able to disable (if not a new entry in byte2byte map with versions)

directly in the player’s rendering area

I still want none of the players to see that I have this mod

Also, if we add client-side setting, the icons won't make sense either, because most people will turn it off

@DearFox
Copy link
Contributor

DearFox commented Mar 19, 2024

should be on the server side

If it's server-side, the player won't be able to disable (if not a new entry in byte2byte map with versions)

directly in the player’s rendering area

I still want none of the players to see that I have this mod

Also, if we add client-side setting, the icons won't make sense either, because most people will turn it off

Still think this is a good feature for those who frequently communicate with people on the server. Well, you know, to understand whether it makes sense to trigger emotions in the player or not. Or maybe the player needs help installing the mod. It's just convenient and informative.
And I don’t see a single reason why you should be afraid of other players knowing whether you have a mod or not. They will still be able to find out by talking to you. If the server uses this mod, it means that the majority will have this mod, and it would be useful for them to know if you have it or not, without asking these questions in the chat.

@dima-dencep
Copy link
Contributor

Or maybe the player needs help installing the mod.

Very interesting how this feature can help
You won't know if the player has blib installed

They will still be able to find out by talking to you

Exactly! That's why I don't see the need for this icon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants