-
Notifications
You must be signed in to change notification settings - Fork 408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hide derived members that are not public #1459
Conversation
BarkingBad
commented
Sep 11, 2020
•
edited
Loading
edited
44068a2
to
400e585
Compare
fun CallableMemberDescriptor.createDRI(wasOverridenBy: DRI? = null): Pair<DRI, DRI?> = | ||
if (kind == CallableMemberDescriptor.Kind.DECLARATION || overriddenDescriptors.isEmpty()) | ||
Pair(DRI.from(this), wasOverridenBy) | ||
else | ||
overriddenDescriptors.first().createDRI(DRI.from(this)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was wrong as it was passing only neighbouring DRI to the next level of recursion. We want the most upper and lower DRIs. Moreover it was wrongly interpreted then as an inheritedFrom
insted of overridenBy
in 361 line
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Anyway, I think it is nice to use this function for visitPropertyDescriptor
as well. I would also change the extra InheritedFunction
to InheritedCallable
and then change presentation of property/function row to something like this
@Kordyjan @sellmair @kamildoleglo what do you think on that?
318d616
to
82d6c56
Compare
I know it's 528 line, but ~500 are just one test. I would keep it more concise though autoformatter had a different opinion about that |
82d6c56
to
6f1ac31
Compare