New breadcrumbs #1590
Merged
New breadcrumbs #1590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcinAman
force-pushed
the
new-breadcrumbs
branch
from
b70d848
to
d2f06dc
Compare
sellophane
reviewed
Oct 26, 2020
| @@ -99,8 +99,7 @@ open class HtmlRenderer( | |||
| node.hasStyle(TextStyle.Span) -> span() { childrenCallback() } | |||
| node.dci.kind == ContentKind.Symbol -> div("symbol $additionalClasses") { childrenCallback() } | |||
| node.dci.kind == ContentKind.BriefComment -> div("brief $additionalClasses") { childrenCallback() } | |||
| node.dci.kind == ContentKind.Cover -> div("cover $additionalClasses") { | |||
| filterButtons(pageContext) | |||
| node.dci.kind == ContentKind.Cover -> div("cover $additionalClasses") { //TODO this can be removed | |||
There was a problem hiding this comment.
For now it is needed as it appends the cover class. I'll fix that in a following PR with refactored HtmlRenderer
MarcinAman
force-pushed
the
new-breadcrumbs
branch
2 times, most recently
from
78d7811
to
47b8f5d
Compare
MarcinAman
force-pushed
the
new-breadcrumbs
branch
from
47b8f5d
to
f133b4e
Compare
Closed
MarcinAman
force-pushed
the
new-breadcrumbs
branch
from
8da7b53
to
788ef8e
Compare
kamildoleglo
approved these changes
Nov 10, 2020
This was referenced Mar 16, 2021
[Dependency]: Bump dokka-gradle-plugin from 0.10.1 to 1.4.30
PatilShreyas/EasyUpiPayment-Android#100
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.