GFM: Use Markdown syntax to render lists #2098
Conversation
|
Can this be run again? The errors in the previous build seem related to a lack of memory, but I don't see how this could be related to the changes. |
|
Updated API file to fix the failing check |
|
I've tried reproducing the Java 11 and 16 tests locally on my windows machine with the same gradle arguments with no luck. I'm seeing a similar paging/connection reset issue on other PRs, but I'm not exactly sure what could be causing this:
Any thoughts on how to debug this? |
JDK 16 on windows sometimes failes as i think they use a weaker machine for that, don't worry. As for the api check: weird, but i see that it passes now so it is ok |
|
@MarcinAman given the only tests failing are on the windows machine, what is the route forward? |
|
please rebase and ping @vmishenev for review and testing |
…hrough the builder DSL - Switch list representation in CommonmarkRenderer.kt to use Markdown syntax instead of HTML - Switch to non-deprecated Assert in SimpleElementsTest.kt
|
Ping @vmishenev. Rebase has been applied |
|
Anything remaining items before this can be merged? |
* - Add ListBuilder to PageContentBuilder.kt to make testing feasible through the builder DSL - Switch list representation in CommonmarkRenderer.kt to use Markdown syntax instead of HTML - Switch to non-deprecated Assert in SimpleElementsTest.kt * Updating base.api to include new builder class and methods
Addresses #2057