Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to new standalone api #3150

Closed

Conversation

darthorimar
Copy link
Contributor

Context: https://youtrack.jetbrains.com/issue/KT-60884

This PR requires the rr/darthorimar/status-resolve-contract branch to the Kotlin repository

Link to the corresponding MR (Internal JetBrains link)

Also, due to the recent changes in how we handle builtins in Analysis API, the update to the fresh version of Analysis API requires registering Kotlin stdlib in every testsuite.

@vmishenev vmishenev self-requested a review August 31, 2023 15:43
@vmishenev vmishenev linked an issue Aug 31, 2023 that may be closed by this pull request
@IgnatBeresnev IgnatBeresnev marked this pull request as draft September 4, 2023 14:12
@IgnatBeresnev
Copy link
Member

IgnatBeresnev commented Sep 4, 2023

I've converted the PR to Draft as an indicator that it's waiting for the changes in Kotlin to be merged, and that it requires some considerable work to make the corresponding tests pass (migrating to the new kotlin-compiler version, unmuting the tests, dealing with k1/k2 inconsistencies, etc).

Note: given that @vmishenev will be on vacation, it's unlikely that we'll get to it sooner than September 18th

@darthorimar
Copy link
Contributor Author

The MR is merged

@vmishenev
Copy link
Member

@darthorimar Hi! Could you rebase onto the main branch and update the version of Analysis API here (e.g, 1.9.30-dev-3330) to merge your PR without broken tests, please?

I can not do it in the fork.

@vmishenev
Copy link
Member

vmishenev commented Oct 11, 2023

I have cherry-picked these commits into the PR #3201 to update the version of Analysis API.
So we are closing this PR in favor of #3201.

@vmishenev vmishenev closed this Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[K2] Migrate to new Standalone Analysis API
3 participants