-
Notifications
You must be signed in to change notification settings - Fork 410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Analysis API to 2.0.20-dev-6911 #3652
Update Analysis API to 2.0.20-dev-6911 #3652
Conversation
List of changes: - KT-68462 - partially KT-68884 and others
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, nice!
Still, there are two things I want to resolve:
- consistent naming: some declarations in AA changed their names, and so some of our functions are also changed, but others don't. I do have two suggestions here, it would be nice to consistently use one of them:
- we change everything to align with the new naming
- we change nothing until AA is stable enough and no renaming is expected
- using of sequences: AFAIU AA almost all the time returns sequences, and in our case we need to handle most of the declarations from those sequences. I believe we should convert them to lists as soon as possible to not stick in a situation that we recreate those sequences on every call. This was the issue which I fixed not so long ago which causes big performance degradation in K2 analysis.
...tlin/org/jetbrains/dokka/analysis/kotlin/symbols/services/SymbolFullClassHierarchyBuilder.kt
Outdated
Show resolved
Hide resolved
...tlin/org/jetbrains/dokka/analysis/kotlin/symbols/services/SymbolFullClassHierarchyBuilder.kt
Outdated
Show resolved
Hide resolved
...tlin/org/jetbrains/dokka/analysis/kotlin/symbols/services/SymbolFullClassHierarchyBuilder.kt
Outdated
Show resolved
Hide resolved
.../main/kotlin/org/jetbrains/dokka/analysis/kotlin/symbols/translators/AnnotationTranslator.kt
Outdated
Show resolved
Hide resolved
.../main/kotlin/org/jetbrains/dokka/analysis/kotlin/symbols/translators/AnnotationTranslator.kt
Outdated
Show resolved
Hide resolved
...ymbols/src/main/kotlin/org/jetbrains/dokka/analysis/kotlin/symbols/translators/DRIFactory.kt
Outdated
Show resolved
Hide resolved
...jetbrains/dokka/analysis/kotlin/symbols/translators/DefaultSymbolToDocumentableTranslator.kt
Outdated
Show resolved
Hide resolved
...jetbrains/dokka/analysis/kotlin/symbols/translators/DefaultSymbolToDocumentableTranslator.kt
Outdated
Show resolved
Hide resolved
...jetbrains/dokka/analysis/kotlin/symbols/translators/DefaultSymbolToDocumentableTranslator.kt
Outdated
Show resolved
Hide resolved
...ls/src/main/kotlin/org/jetbrains/dokka/analysis/kotlin/symbols/translators/TypeTranslator.kt
Show resolved
Hide resolved
I am trying to do the former to avoid forgotten context. My approach is
I agree, it is a good point. Using sequences from AA should be moderated. |
a5e1351
to
ef9bf7f
Compare
List of changes: