Add Conv1D impementation #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zaleslaw
requested changes
May 31, 2021
api/src/main/kotlin/org/jetbrains/kotlinx/dl/api/core/layer/convolutional/Conv2D.kt
Outdated
Show resolved
Hide resolved
api/src/main/kotlin/org/jetbrains/kotlinx/dl/api/core/layer/convolutional/Conv1D.kt
Outdated
Show resolved
Hide resolved
api/src/main/kotlin/org/jetbrains/kotlinx/dl/api/core/layer/convolutional/Conv1D.kt
Outdated
Show resolved
Hide resolved
api/src/main/kotlin/org/jetbrains/kotlinx/dl/api/core/layer/convolutional/Conv2D.kt
Outdated
Show resolved
Hide resolved
api/src/main/kotlin/org/jetbrains/kotlinx/dl/api/core/layer/convolutional/ConvPadding.kt
Outdated
Show resolved
Hide resolved
api/src/main/kotlin/org/jetbrains/kotlinx/dl/api/core/layer/convolutional/DepthwiseConv2D.kt
Show resolved
Hide resolved
api/src/main/kotlin/org/jetbrains/kotlinx/dl/api/core/layer/convolutional/DepthwiseConv2D.kt
Show resolved
Hide resolved
api/src/main/kotlin/org/jetbrains/kotlinx/dl/api/core/shape/ShapeFunctions.kt
Show resolved
Hide resolved
|
@avan1235 Please merge the master branch, it helps me to run examples on your branch |
avan1235
force-pushed
the
avan1235/conv1d-impl
branch
from
bd4149f
to
e91fa5e
Compare
|
@zaleslaw I did the rebase and now it should have the newest source code from master |
|
@avan1235 I recognized that the layer export/import is missing. |
avan1235
force-pushed
the
avan1235/conv1d-impl
branch
from
fb69c28
to
865e881
Compare
|
@zaleslaw thanks for pointing this out, I've now added the proper functions in ModelLoader and ModelSaver |
zaleslaw
added
LGTM
avan1235
force-pushed
the
avan1235/conv1d-impl
branch
from
865e881
to
b9f3567
Compare
|
LGTM for me, first in the queue to merge at this moment, I'll run the TC build and merge if there are no new issues there. |
|
Great, just rebased the branch to enable testing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #59
I wasn't able to hide the Conv2DImpl class in any way that come to my mind, maybe you have some idea.
My first approach was to create
delegatefield in Conv1D but then there is problem with Layer functions that are not visible and imo should also be then overriden by withdelegatecallsI create a few helper internal functions in ShapeFunctions they maybe useful in more places than the conv tests but I wasn't sure if this is the best place for them.
If implementation and helper function will be ok I can think of some extra tests (I'm open to suggestions)