Add GlobalAvgPool1D Layer #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
therealansh
changed the title
|
The unit tests written right now are only for GlobalAvgPool1D extending the PoolingTest class. With the help of helper functions written by @avan1235 in the ShapeFunctions |
6 tasks
zaleslaw
approved these changes
Jun 1, 2021
There was a problem hiding this comment.
So, this LGTM for me also I'd like the tests, it's a great implementation and very clear for now
I suggest removing some blank lines in some places, but it's ready for merge.
There is a queue of PRs, I'll notify you when you should merge master into your branch (in a few days) and your PR will be merged
api/src/main/kotlin/org/jetbrains/kotlinx/dl/api/core/layer/pooling/GlobalAvgPool1D.kt
Outdated
Show resolved
Hide resolved
api/src/main/kotlin/org/jetbrains/kotlinx/dl/api/core/layer/pooling/GlobalAvgPool1D.kt
Outdated
Show resolved
Hide resolved
api/src/main/kotlin/org/jetbrains/kotlinx/dl/api/core/layer/pooling/GlobalAvgPool1D.kt
Outdated
Show resolved
Hide resolved
api/src/test/kotlin/org/jetbrains/kotlinx/dl/api/core/layer/PoolLayerTest.kt
Outdated
Show resolved
Hide resolved
api/src/test/kotlin/org/jetbrains/kotlinx/dl/api/core/layer/PoolLayerTest.kt
Outdated
Show resolved
Hide resolved
api/src/test/kotlin/org/jetbrains/kotlinx/dl/api/core/layer/GlobalAvgPooling1DTest.kt
Outdated
Show resolved
Hide resolved
api/src/test/kotlin/org/jetbrains/kotlinx/dl/api/core/layer/PoolLayerTest.kt
Outdated
Show resolved
Hide resolved
zaleslaw
added
Review
|
So you could merge the master branch and I'll merge your PR in two days |
therealansh
force-pushed
the
GblAvgPool1d-impl
branch
from
aad5f01
to
73b48df
Compare
|
Congrats, @therealansh thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds GlobalAvgPool1D layer (#63). Also renamed the file to "GlobalAvgPooling2D" from "GlovalAvgPooling2d"(typo).
TODO: