Cleanup JobSupport slightly #4079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qwwdfsad
reviewed
Apr 3, 2024
dkhalanskyjb
force-pushed
the
dk-jobsupport-cleanup
branch
3 times, most recently
from
0c6c6e3
to
c422fcd
Compare
Before this change, there were some extra classes/interfaces that were immediately wrapped in other classes and so serve no real purpose. These classes are removed, slightly reducing the number of allocations in some cases and simplifying the code.
It's only used once during initialization, no need to store it if we can explicitly pass it to the initialization sequence.
dkhalanskyjb
force-pushed
the
dk-jobsupport-cleanup
branch
from
056a34b
to
250b9d5
Compare
qwwdfsad
approved these changes
Apr 8, 2024
Corje
pushed a commit
that referenced
this pull request
May 10, 2024
This change simplifies some code used in for `JobSupport`: there are fewer wrapper classes, the information is passed between functions with less duplication, and some API was either removed due to being unused, or moved to reduce its visibility.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change, there were some extra classes/interfaces that were immediately wrapped in other classes and so serve no real purpose. These classes are removed, slightly reducing the number of allocations in some cases and simplifying the code.
Follow-up to #4010