Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicates finder #112

Closed
newpdv opened this issue Apr 25, 2020 · 3 comments · Fixed by #129
Closed

Duplicates finder #112

newpdv opened this issue Apr 25, 2020 · 3 comments · Fixed by #129
Labels
Enhancement Any requests for improvements or new features
Milestone

Comments

@newpdv
Copy link

newpdv commented Apr 25, 2020

A good function is to search for duplicate links, both when adding a link, and after import.

P.S. All garbage from URL (protocol, www, trailing slashes, useless query parameters or hash strings) should be ignored.

@Kovah
Copy link
Owner

Kovah commented Apr 26, 2020

Sounds good, maybe this could be integrated into the regular link checks.

@Kovah Kovah added the Enhancement Any requests for improvements or new features label Apr 26, 2020
@Kovah Kovah modified the milestones: v0.0.36, v0.0.37 May 6, 2020
@Kovah
Copy link
Owner

Kovah commented Jun 1, 2020

I am currently thinking about the actual implementation.

My first idea of integrating it into the regular link checks, but there are some flaws. As the current link checks are mean to check the accessibility of resources, the duplicate check maintains database consistency. Putting both into the same boat does not seem to fit. Also, getting information about duplicate links each once in a while when links are checked seem annoying.

Having the checks available as a search feature does not seem to fit too. Having to run it manually is tedious and not a straight forward help to reduce duplicates.

My current best bet would be to integrate this feature into the link creation process. After saving a link, we could run an additional check for duplicates. If some are found, they are pushed to the frontend with a notification.

@newpdv What do you think?

@newpdv
Copy link
Author

newpdv commented Jun 1, 2020

Hello! I think a forced link check is not needed if we keep the database up to date, checking all links when adding or importing. And additional check when changing link.

@Kovah Kovah linked a pull request Jun 2, 2020 that will close this issue
@Kovah Kovah closed this as completed in #129 Jun 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Any requests for improvements or new features
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants