-
Notifications
You must be signed in to change notification settings - Fork 439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KOrganizer/Kontact cannot delete from Radicale CalDav (412 Precondition Failed) #117
Comments
Well, the last code snippet came from a patched version. Sorry, the bug report was against 0.7.0 and 4 months ago, that's why I thought it got into in 0.8.0. Please, release a new version as soon as possible, because one cannot delete items from one's calendar. |
I ran into the same issue using newest Windows Phone 8 version and radicale 0.10, creation of entries works fine, but delete won't work: DEBUG: Answer status: 412 Precondition Failed |
@pbiering Please post the full debug logs of Radicale (or capture them yourself with e.g. mitproxy). This bug has been fixed ages ago. |
Log from an ical entry created by Thunderbird SOGO, synced with WP and then try to delete by WP, which is not working. Server: radicale 0.10
|
This patch is supposed to work: diff --git a/radicale/__init__.py b/radicale/__init__.py
index 55329e5..ad8fbba 100644
--- a/radicale/__init__.py
+++ b/radicale/__init__.py
@@ -382,8 +382,8 @@ class Application(object):
if item:
# Evolution bug workaround
- etag = environ.get("HTTP_IF_MATCH", item.etag).replace("\\", "")
- if etag == item.etag:
+ if_match = environ.get("HTTP_IF_MATCH", "*").replace("\\", "")
+ if if_match in ("*", item.etag):
# No ETag precondition or precondition verified, delete item
answer = xmlutils.delete(environ["PATH_INFO"], collection)
return client.OK, {}, answer |
Great, this fixed this issue - thank you for the fast response! |
When I try to delete a calendar event from Kontact, I get an error message every time.
Here are the debug messages from Kontact:
Interestingly, from my N9 phone it works perfectly:
I see 3 differences:
Versions:
Maybe the fix for #73 was not full. Eg. I found in ical.py the following line (:122) which still uses the build-in hash function:
Although in :427 the new hash function is used:
The text was updated successfully, but these errors were encountered: