Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing link to weasyprint.org/#samples/ #2211

Merged
merged 2 commits into from
Jul 29, 2024
Merged

Fixing link to weasyprint.org/#samples/ #2211

merged 2 commits into from
Jul 29, 2024

Conversation

gteti
Copy link
Contributor

@gteti gteti commented Jul 26, 2024

No description provided.

@liZe
Copy link
Member

liZe commented Jul 26, 2024

Hi!

Thanks for this pull request.

That’s an example showing how links work with WeasyPrint, fixing this URL is not consistent with the explanation above. There’s only a home page on WeasyPrint’s website now, so we have to change the example. Maybe you could use the https://www.courtbouillon.org/blog-articles/ URL, changing /samples/ into /blog-articles/ and WeasyPrint into CourtBouillon?

@gteti
Copy link
Contributor Author

gteti commented Jul 26, 2024

Hi!

Thanks for this pull request.

That’s an example showing how links work with WeasyPrint, fixing this URL is not consistent with the explanation above. There’s only a home page on WeasyPrint’s website now, so we have to change the example. Maybe you could use the https://www.courtbouillon.org/blog-articles/ URL, changing /samples/ into /blog-articles/ and WeasyPrint into CourtBouillon?

Since the link is clickable in the rendered readthedocs documentation I thought it was intended and it was something to change.
Sorry 😄

@liZe liZe merged commit e6bf69a into Kozea:main Jul 29, 2024
6 checks passed
@liZe liZe added the documentation Problems or improvements needed on the documentation or on the website label Jul 29, 2024
@liZe liZe added this to the 63.0 milestone Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Problems or improvements needed on the documentation or on the website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants