Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new guild attributes #585

Merged
merged 3 commits into from
May 7, 2024
Merged

Add new guild attributes #585

merged 3 commits into from
May 7, 2024

Conversation

jb3
Copy link
Collaborator

@jb3 jb3 commented May 5, 2024

Adds a heap of guild attributes upstream from Discord that we had not yet added to the guild struct.

Details of new attributes are contained within the added typedocs in the changelog, for brevity I will not list them again here.

@jchristgit jchristgit self-assigned this May 6, 2024
@jchristgit jchristgit self-requested a review May 6, 2024 05:51
Copy link
Collaborator

@jchristgit jchristgit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good. Some minor nitpicks.

lib/nostrum/struct/guild.ex Outdated Show resolved Hide resolved
lib/nostrum/struct/guild.ex Outdated Show resolved Hide resolved
lib/nostrum/struct/guild.ex Outdated Show resolved Hide resolved
lib/nostrum/struct/guild.ex Show resolved Hide resolved
lib/nostrum/struct/guild.ex Outdated Show resolved Hide resolved
lib/nostrum/struct/guild/system_channel_flags.ex Outdated Show resolved Hide resolved
Copy link
Collaborator

@jchristgit jchristgit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jchristgit jchristgit merged commit 45c892e into master May 7, 2024
9 checks passed
@jb3 jb3 deleted the jb3/guild-attributes branch May 8, 2024 03:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants