Add hal.h from the prima driver #1
Conversation
In START_RSP message status filed is 2 bytes but not 4 as in all other responses. Because of that check for status was always failing all the time. As a fix check for success only 2 bytes. Signed-off-by: Eugene Krasnikov <eugene.krasnikov@sonymobile.com>
URL: https://www.codeaurora.org/gitweb/external/wlan/?p=prima.git;a=blob_plain;f=riva/inc/wlan_hal_msg.h;h=f29aaf66e59c566cde4bd99bc2b00024641aac21;hb=HEAD Signed-off-by: Kalle Valo <kvalo@qca.qualcomm.com>
From URL: https://www.codeaurora.org/gitweb/external/wlan/?p=prima.git;a=blob_plain;f=riva/inc/wlan_qct_dev_defs.h;h=b9577e6bd173b3e44d83bfc40d852b381585c6ca;hb=HEAD hal.h needs these Signed-off-by: Kalle Valo <kvalo@qca.qualcomm.com>
So that we can use it with wcn36xx. Signed-off-by: Kalle Valo <kvalo@qca.qualcomm.com>
Follow Linux style and use real structs and __packed. Signed-off-by: Kalle Valo <kvalo@qca.qualcomm.com>
Signed-off-by: Kalle Valo <kvalo@qca.qualcomm.com>
Signed-off-by: Kalle Valo <kvalo@qca.qualcomm.com>
Signed-off-by: Kalle Valo <kvalo@qca.qualcomm.com>
Leave the ones which change structure content, these need to be solved somehow differently. Also fix few compiler errors which happened due to #ifdef removal. Signed-off-by: Kalle Valo <kvalo@qca.qualcomm.com>
Signed-off-by: Kalle Valo <kvalo@qca.qualcomm.com>
Lindent reformatted it in a really ugly way. Signed-off-by: Kalle Valo <kvalo@qca.qualcomm.com>
Signed-off-by: Kalle Valo <kvalo@qca.qualcomm.com>
Signed-off-by: Kalle Valo <kvalo@qca.qualcomm.com>
|
enums like eSIR_WEP_STATIC must be renamed |
|
enums like eSTA_11ac must be removed since HW is not supporting 11ac |
|
suggest also to change variable name to something more linux friendli e.g. ucMaxBssids change to max_bssids |
|
Also suggest to change PE_SUMMARY_STATS_INFO to something else because PE is a similar to SIR(one of the layers in prima driver) and not valid for wcn36xx any more |
|
In most cases we should use WCN36XX_HAL where it’s not excessive KrasnikovEugene notifications@github.com writes:
Maybe I should use WCN36XX_HAL_ and wcn36xx_hal_ prefixes everywhere? Kalle Valo |
| /* | ||
| * Copyright (c) 2012, The Linux Foundation. All rights reserved. | ||
| * | ||
| * Previously licensed under the ISC license by Qualcomm Atheros, Inc. |
There was a problem hiding this comment.
copyrights twice. probably to excessive;)
There was a problem hiding this comment.
KrasnikovEugene notifications@github.com writes:
In hw.h:
- * above copyright notice and this permission notice appear in all
- * copies.
- * THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL
- * WARRANTIES WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED
- * WARRANTIES OF MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE
- * AUTHOR BE LIABLE FOR ANY SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL
- * DAMAGES OR ANY DAMAGES WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR
- * PROFITS, WHETHER IN AN ACTION OF CONTRACT, NEGLIGENCE OR OTHER
- * TORTIOUS ACTION, ARISING OUT OF OR IN CONNECTION WITH THE USE OR
- * PERFORMANCE OF THIS SOFTWARE.
- /
+/- * Copyright (c) 2012, The Linux Foundation. All rights reserved.
- * Previously licensed under the ISC license by Qualcomm Atheros, Inc.
copyrights twice. probably to excessive;)
I have already removed hw.h from my branch already, we just needed one
define from hw.h.
Kalle Valo
|
I suggest to remove this. #define IS_MCC_SUPPORTED_BY_HOST (!!(halMsg_GetHostWlanFeatCaps(MCC))) |
The 'e' prefix is useless. Signed-off-by: Kalle Valo <kvalo@qca.qualcomm.com>
We actually just need just HAL_NUM_BSSID from hw.h. So copy that to hal.h and delete hw.h entirely. Signed-off-by: Kalle Valo <kvalo@qca.qualcomm.com>
Simplify them and get rid of camel case style. Signed-off-by: Kalle Valo <kvalo@qca.qualcomm.com>
Signed-off-by: Kalle Valo <kvalo@qca.qualcomm.com>
Signed-off-by: Kalle Valo <kvalo@qca.qualcomm.com>
Signed-off-by: Kalle Valo <kvalo@qca.qualcomm.com>
Signed-off-by: Kalle Valo <kvalo@qca.qualcomm.com>
Signed-off-by: Kalle Valo <kvalo@qca.qualcomm.com>
Signed-off-by: Kalle Valo <kvalo@qca.qualcomm.com>
Signed-off-by: Kalle Valo <kvalo@qca.qualcomm.com>
Signed-off-by: Kalle Valo <kvalo@qca.qualcomm.com>
Signed-off-by: Kalle Valo <kvalo@qca.qualcomm.com>
|
Ok, there is so many changes already so we have to merge this and start to use it. Let's just file issues when we found something. |
Add hal.h from the prima driver
This pull requests adds hal.h from the prima driver. The benefit from this is that we use the same terms as the prima driver.
I did a lot of cleanup but there's still few pendings pending, for example endian support, few typedefs and structure field names. I'll clean those later.