Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core] Modify coordinate_transformation_utilities.h to allow transformation back to global coordinates #12327

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

gzjing
Copy link
Contributor

@gzjing gzjing commented Apr 27, 2024

The coordinate_transformation_utilities.h is modified slightly to allow rotation of the contributions back to the global frame of reference. This change is necessary for the refactoring of particle-based slip for the MPMApplication (#12018), where it was decided to rotate the contributions of particle-based conditions back to the global frame of reference after correcting for SLIP to avoid complications with mis-aligned frames of reference.

The changes made are as follows:

  • Use template boolean TToGlobalCoord (default false) in RotateAux and RotateAuxPure, transposing the rotation matrix when this is set to true to allow rotation back to the global coordinate system
  • Extracted RHS version of Rotate to RotateRHSAux to allow a similar process to be done without affecting the existing interface

@gzjing gzjing requested a review from a team as a code owner April 27, 2024 22:21
@gzjing gzjing changed the title Modify coordinate_transformation_utilities.h to allow transformation back to global coordinates [Core] Modify coordinate_transformation_utilities.h to allow transformation back to global coordinates May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant