-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Core] Modify coordinate_transformation_utilities.h to allow transformation back to global coordinates #12327
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
a389d45
Refactor coordinate_transformation_utilities.h to allow transformatio…
gzjing 6ecadbf
Update kratos/utilities/coordinate_transformation_utilities.h
VeronikaSinger bec795b
RotateRHSAux private, Indentation, rename TToGlobalCoord
VeronikaSinger be4d308
Merge branch 'master' into mpm/refactor_rotation_utility
gzjing 73ff95f
Minor edit
gzjing 7fdb38d
Update kratos/utilities/coordinate_transformation_utilities.h
gzjing 2b84a26
Update kratos/utilities/coordinate_transformation_utilities.h
gzjing 8626a5d
fix bug from variable renaming
gzjing dd03f83
Add documentations
gzjing 48515dd
Update kratos/utilities/coordinate_transformation_utilities.h
gzjing File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is no longer needed right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately, the rotate operation on the LHS in
MPMApplication
is implemented differently from the core. We thus require the two versions ofRotateAux
with the ability to revert the rotation applied. Since this is already an auxillary function, making the changes here directly makes more sense in my opinion (as compared to extracting the contents to yet another aux function). I can add some documentation here if you think the changes might be confusing.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense for me. I just wanted to confirm that this was not a leftover.