[Core] Deprecate old projection methods #9024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rubenzorrilla
commented
Aug 9, 2021
There was a problem hiding this comment.
@tteschemacher changes have been done accordingly. I also agree on adding the deprecation warning in the "standard" geometries only.
…d brep geometries
# Conflicts: # kratos/geometries/brep_curve.h # kratos/geometries/brep_curve_on_surface.h # kratos/geometries/brep_surface.h # kratos/geometries/nurbs_curve_geometry.h # kratos/geometries/nurbs_curve_on_surface_geometry.h # kratos/geometries/nurbs_surface_geometry.h
|
It seems that there is a |
|
@tteschemacher it seems that there are still some issues with the debug compilations. |
here we go. |
|
@rubenzorrilla @roigcarlo this is finished from my side and I think we should merge as soon as possible to avoid further conflicts. |
|
Completely agree, but I we need someone to review / approve it. |
roigcarlo
previously approved these changes
Aug 30, 2021
roigcarlo
approved these changes
Sep 13, 2021
tteschemacher
approved these changes
Sep 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR deprecates the old
ProjectionPointmethod according to the discussion in #8491. So far only the "simple" geometries have been modified. @tteschemacher will proceed with the IGA-related geometries.ClosestPointmethod will be deprecated in an future PR.Changelog
Deprecation of the
ProjectPointmethod in favor of theProjectPointLocalToLocalSpaceandProjectPointGlobalToLocalSpace.