-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Core][Geometry] Old closest point deprecation #9243
[Core][Geometry] Old closest point deprecation #9243
Conversation
Thanks for the changes. Shall we add a date until when this function will be removed completely? |
// Projection failed | ||
return -1; | ||
} | ||
return ClosestPointGlobalToLocalSpace(rPointGlobalCoordinates, rClosestPointLocalCoordinates, Tolerance); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
return ClosestPointGlobalToLocalSpace(rPointGlobalCoordinates, rClosestPointLocalCoordinates, Tolerance); | |
const int result = ClosestPointGlobalToLocalSpace(rPointGlobalCoordinates, rClosestPointLocalCoordinates, Tolerance); | |
if (result == 1) { | |
this->GlobalCoordinates(rClosestPointGlobalCoordinates, local_coordinates); | |
} | |
return result; |
Not that this is of major importance as it will be removed. But I think the correct term is as this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree. But note that I'm keeping the previous behavior, which was wrong (see the deprecation message).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, no worries, then.
I think we should. Considering that there are only a very few usages I think we can safely remove them after the release. |
Sounds good to me. I have removed my use cases. I'd be fine with the removal. |
📝 Description
This PR follows #9024 to deprecate the old
ClosestPoint
methods from theGeometry
class as we agreed in #8491.🆕 Changelog
Please summarize the changes in one list to generate the changelog:
E.g.
ClosestPoint
method in favor of theClosestPointGlobalToLocalSpace
andClosestPointLocalToLocalSpace
.