3D-Waterfall example

[MatFi]

See this post. Have added some beautifications. I'm not sure if this is done correctly.

[KristofferC]

That's a beautiful plot.

[KristofferC]

I think you need to add Distributions to

PGFPlotsX.jl/Project.toml

Line 20 in bed8c09

[extras]

and https://github.com/KristofferC/PGFPlotsX.jl/blob/master/docs/make.jl#L4.

[tpapp]

Thanks for this very nice contribution.

Please don't consider whitespace consistency requests nitpicking, we try to maintain a nicely formatted example collection.

[codecov-io]

Codecov Report

Merging #191 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #191   +/-   ##
=======================================
  Coverage   84.92%   84.92%           
=======================================
  Files           9        9           
  Lines         577      577           
=======================================
  Hits          490      490           
  Misses         87       87

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bed8c09...1da0a0b. Read the comment docs.

[tpapp]

@KristofferC: you are the Pkg expert here, but wouldn't it be enough to add Distributions to docs/Project.toml?

[KristofferC]

Yeah maybe, but I think we load it in make.jl to prevent it from precompiling during doc generation and then emitting Precompiling .... into the docs.

[tpapp]

But in that case, it having it in [extras] and then [targets] should be enough?

[KristofferC]

But in that case, it having it in [extras] and then [targets] should be enough?

Yes.

[KristofferC]

Ah, but we use a separate project for the docs: https://github.com/KristofferC/PGFPlotsX.jl/blob/master/docs/Project.toml

[MatFi]

But in that case, it having it in [extras] and then [targets] should be enough?

Yes.

Hm, then it actually a bit lost/ to stupid, I don't get why the tests fail

EDIT:

Ah, but we use a separate project for the docs: https://github.com/KristofferC/PGFPlotsX.jl/blob/master/docs/Project.toml

Ok i add it there. still loading Distributions in make.jl ?

[KristofferC]

Ok i add it there. still loading Distributions in make.jl ?

I think so, yes.

[tpapp]

you are still missing an actual included figure here, see the other examples

[tpapp]

@MatFi: this is getting there, you still need to include the figure. I would recommend rendering the docs locally, with

julia --project=@. make.jl

in the docs/ subdirectory, output will be in build/. Please check how it looks, in particular some lines are too long to display without wrap and should be broken up.

[KristofferC]

I pushed a commit here with some style fixes (and some other things, like not updating Documenter in this PR and fixing a deprecation warning in the pdf usage). It now show up in the docs.