Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sigil terminator escapes are not recognized #14

Closed
KronicDeth opened this issue Oct 14, 2014 · 0 comments · Fixed by #17
Closed

Sigil terminator escapes are not recognized #14

KronicDeth opened this issue Oct 14, 2014 · 0 comments · Fixed by #17
Assignees
Labels
Milestone

Comments

@KronicDeth
Copy link
Owner

The current set of VALID_ESCAPE_SEQUENCE

VALID_ESCAPE_SEQUENCE = {ESCAPED_DOUBLE_QUOTES} |
                        {ESCAPED_SINGLE_QUOTE} |
                        {ESCAPED_INTERPOLATION_START}

is too limited and misses escapes of sigil terminators.
screen shot 2014-10-13 at 7 56 49 pm

Not only should the sigil terminators be escapable, but VALID_ESCAPE_SEQUENCE needs to be updated to cover all escapes that Elixir's lexer handles.

@KronicDeth KronicDeth self-assigned this Oct 14, 2014
@KronicDeth KronicDeth modified the milestone: v1.0.0 Oct 14, 2014
KronicDeth added a commit that referenced this issue Oct 15, 2014
Closes #14

Test that escaping sigil terminators prevents sigil termination to
ensure that #14 is fixed by implementing all valid escape sequences for
 #15.
KronicDeth added a commit that referenced this issue Oct 15, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant