Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make it work with setuptools v46 #386

Merged
merged 1 commit into from Mar 20, 2020
Merged

make it work with setuptools v46 #386

merged 1 commit into from Mar 20, 2020

Conversation

hrw
Copy link
Contributor

@hrw hrw commented Mar 11, 2020

pyScss fails to install with setuptools v46 because of use of removed Feature feature.

This fixes the problem.

@coveralls
Copy link

coveralls commented Mar 11, 2020

Coverage Status

Coverage remained the same at 66.809% when pulling 6ec33af on hrw:master into 3135891 on Kronuz:master.

@yoctozepto
Copy link

travis b0rken

@e0ne
Copy link
Collaborator

e0ne commented Mar 12, 2020

I hope it will be merged soon and we'll have a new release for pyScss

@e0ne
Copy link
Collaborator

e0ne commented Mar 13, 2020

BTW, I forked this project and released as pyScss2 https://github.com/e0ne/pyScss/

@yoctozepto
Copy link

I guess you'd prefer to use https://github.com/e0ne/pyScss

@hrw
Copy link
Contributor Author

hrw commented Mar 18, 2020

I should branch...

@Kronuz
Copy link
Owner

Kronuz commented Mar 18, 2020

@hrw, @e0ne, I guess if you guys are interested, I can add you as maintainers so you can help out

@e0ne
Copy link
Collaborator

e0ne commented Mar 18, 2020

@Kronuz I can't promise that I'll be able to develop new features, but I'm interested in maintaining it until OpenStack Horizon uses this project

@hrw
Copy link
Contributor Author

hrw commented Mar 18, 2020

@Kronuz I have to admit that I do not even know what this project does. It is dependency of Horizon which failed so project where I work (Kolla) failed.

So I went and provided fix. Then looked and updated Travis CI.

Can provide some basic support for infrastructure part but not for it's code.

@e0ne
Copy link
Collaborator

e0ne commented Mar 20, 2020

Thanks for the fix, @hrw !

@e0ne e0ne merged commit 08e8ae4 into Kronuz:master Mar 20, 2020
The-Compiler added a commit to studentenportal/web that referenced this pull request Mar 21, 2020
This restores compatibility with newer setuptools versions:

Kronuz/pyScss#386
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants