Skip to content
This repository has been archived by the owner on Dec 17, 2019. It is now read-only.

Make compiler errors a little easier to read #251

Merged
merged 1 commit into from
Aug 28, 2018

Conversation

norpan
Copy link
Contributor

@norpan norpan commented Aug 27, 2018

I had a hard time reading the errors from Elm 0.19, because it uses color to signal the relevant information. However, it seems we can't have color in the vscode.Diagnostic, so I propose we put '#' around all parts of compiler errors that are decorated.

I had a hard time reading the errors from Elm 0.19, because it uses color to signal the relevant information. However, it seems we can't have color in the vscode.Diagnostic, so I propose we put '#' around all parts of compiler errors that are decorated.
@norpan
Copy link
Contributor Author

norpan commented Aug 27, 2018

#number# here is the type that is wrong
hashes

@7sharp9
Copy link

7sharp9 commented Aug 27, 2018 via email

@norpan
Copy link
Contributor Author

norpan commented Aug 27, 2018

Unfortunately yes, it seems that compiler errors can't be styled. Other hover popups can be styled.

@7sharp9
Copy link

7sharp9 commented Aug 28, 2018

@hakonrossebo What do you think?

@hakonrossebo
Copy link
Contributor

I would say we could do this now, and it's easy to fix later if we find another solution.

@Krzysztof-Cieslak Krzysztof-Cieslak merged commit 7b7ed8e into elm-tooling:master Aug 28, 2018
@Krzysztof-Cieslak
Copy link
Member

Thanks a lot!

@norpan
Copy link
Contributor Author

norpan commented Dec 7, 2018

A feature request with vscode to allow styling diagnostics is here: microsoft/vscode#54272

@razzeee
Copy link
Member

razzeee commented Jan 18, 2019

The thing i don't like about this is that some messages use the '^' sign to mark an error. But this now gets moved 1 character to the right which might be wrong or confusing

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants