Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modal-gallery In a Modal #95

Closed
daylenlim opened this issue Oct 10, 2017 · 9 comments
Closed

Modal-gallery In a Modal #95

daylenlim opened this issue Oct 10, 2017 · 9 comments

Comments

@daylenlim
Copy link

daylenlim commented Oct 10, 2017

Is it possible to use Modal-gallery in a Modal?

I'm using the BsModalService to generate the modal.
https://valor-software.com/ngx-bootstrap/#/modals

my result as below ->

capture

my expected result is the gallery can cover the full screen,
any suggestions?

@Ks89
Copy link
Owner

Ks89 commented Oct 10, 2017

This is a good question. I never thought about this scenario.

I'll schedule this for version 4.0.0 or greater.

@daylenlim
Copy link
Author

Thanks for your prompt reply. 👍
I'm looking forward to version 4.0.0. :)

@Ks89
Copy link
Owner

Ks89 commented Nov 23, 2017

@daylenlim Hi, can I ask you a small thing?

Do you have a working example of a Modal dialog on https://plnkr.co/ with the latest beta version of ngx-bootstrap 2?

I started to work on this feature, but I need small help, because it is quite difficult.

@Ks89
Copy link
Owner

Ks89 commented Nov 29, 2017

It could be a good idea to test both ngx-bootstrap 2 and ng-bootstrap (latest releases, also if still beta versions)

If someone want to help me, please provide me two plunkr's examples with these libraries to show modal dialogs. Also, If you want to add angular-modal-gallery inside the dialogs to these examples, it will be really appreciated.

This feature might be quite difficult to implement, so I need help. Otherwise, it will be probably released in future minor versions of angular-modal-gallery 5.x.x and not with 5.0.0.

I'll add every testers and contributors to the official readme of 5.0.0, when released.

@SeanBreathnach
Copy link

I had this issue (an image gallery running from within a modal)
Adding the below to my styles fixed it for me:

.modal.show .modal-dialog { transform:none; }

@Ks89
Copy link
Owner

Ks89 commented Jul 10, 2018

Interesting @SeanBreathnach I'll try it.

Adding the below to my styles

Did you add that css to angular's global style? Or inside the component with the modal gallery?

@Ks89
Copy link
Owner

Ks89 commented Jul 11, 2018

Interesting I'll try this weekend

@Ks89
Copy link
Owner

Ks89 commented Jul 15, 2018

Hi @SeanBreathnach which library are you using to create modal dialog?

@Ks89
Copy link
Owner

Ks89 commented Apr 11, 2020

Fully implemented (branch 800) thanks to angular/cdk and scheduled for 8.0.0-beta.1 that is coming soon.

I close this issue because already done and It will be available in a beta release in some days.

@Ks89 Ks89 closed this as completed Apr 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants