Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-queue validation intermittently #36

Closed
4 tasks
philbrookes opened this issue Mar 1, 2024 · 0 comments · Fixed by #66
Closed
4 tasks

Re-queue validation intermittently #36

philbrookes opened this issue Mar 1, 2024 · 0 comments · Fixed by #66

Comments

@philbrookes
Copy link
Collaborator

philbrookes commented Mar 1, 2024

To ensure consistency across all of our clusters, we will need to occasionally queue a verification check to ensure the zone looks as expected for the local cluster.

To do this, when a verification reconcile finishes successfully (thereby setting the count of failed verifications in the status to 0), it should be requeued for 15 minutes later to re-verify and update the DNS Record status if required.

Update status with the next queued time and the time it was queued and valid length.

Requeue time should have a sane default (e.g. 15 minutes) and be possible to override as a flag to the runtime.

When observedGeneration == generation and the time it was queued is younger than valid length old - do not go to DNS Provider API actions, only verify metadata, e.g. finalizers.

  • Delay added with default value in main.go
  • Status updated with next queued reconcile
  • Flag to override this value to a custom value
  • Tests added / updated
@maksymvavilov maksymvavilov self-assigned this Mar 21, 2024
maksymvavilov added a commit that referenced this issue Mar 27, 2024
@maksymvavilov maksymvavilov linked a pull request Mar 27, 2024 that will close this issue
maksymvavilov added a commit that referenced this issue Apr 3, 2024
maksymvavilov added a commit that referenced this issue Apr 3, 2024
maksymvavilov added a commit that referenced this issue Apr 3, 2024
maksymvavilov added a commit that referenced this issue Apr 4, 2024
maksymvavilov added a commit that referenced this issue Apr 4, 2024
maksymvavilov added a commit that referenced this issue Apr 4, 2024
maksymvavilov added a commit that referenced this issue Apr 4, 2024
maksymvavilov added a commit that referenced this issue Apr 4, 2024
maksymvavilov added a commit that referenced this issue Apr 4, 2024
maksymvavilov added a commit that referenced this issue Apr 4, 2024
maksymvavilov added a commit that referenced this issue Apr 5, 2024
maksymvavilov added a commit that referenced this issue Apr 5, 2024
maksymvavilov added a commit that referenced this issue Apr 5, 2024
maksymvavilov added a commit that referenced this issue Apr 5, 2024
maksymvavilov added a commit that referenced this issue Apr 5, 2024
maksymvavilov added a commit that referenced this issue Apr 5, 2024
maksymvavilov added a commit that referenced this issue Apr 5, 2024
maksymvavilov added a commit that referenced this issue Apr 5, 2024
maksymvavilov added a commit that referenced this issue Apr 11, 2024
maksymvavilov added a commit that referenced this issue Apr 11, 2024
github-merge-queue bot pushed a commit that referenced this issue Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants