Добавил отображение подсказок на латинице в адресах #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: arcane418 <arcane561@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #18 +/- ##
============================================
- Coverage 99.06% 98.45% -0.61%
Complexity 142 142
============================================
Files 45 45
Lines 321 324 +3
Branches 1 1
============================================
+ Hits 318 319 +1
- Misses 3 5 +2
Continue to review full report at Codecov.
|
KuliginStepan
requested changes
Aug 15, 2020
| @@ -43,9 +44,15 @@ public AddressRequestBuilder restrictValue() { | |||
| return this; | |||
| } | |||
|
|
|||
| public AddressRequestBuilder outputLanguage(String language) { | |||
There was a problem hiding this comment.
Предлагаю сделать более типизировано: у нас есть конечный список языков, которые поддерживаются – это русский (ru) и английский (en). Можно сделать Enum, например:
public enum Language {
EN,
RU
}
А при создании AddressRequest делать такое: language.name().toLower()
| @@ -25,17 +25,21 @@ | |||
| private Map<String, String> toBound; | |||
| @JsonProperty("restrict_value") | |||
| private Boolean restrictValue; | |||
| @JsonProperty("language") | |||
There was a problem hiding this comment.
Если название поля совпадает с полем в json, то аннотацию @JsonProperty не обязательно ставить
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Обнаружил, что такой функции нет, использовать предлагается вот так:
и если нужны на русском, то ничего добавлять не нужно: