Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify array metadata #10

Merged
merged 12 commits into from
Dec 21, 2016
Merged

Unify array metadata #10

merged 12 commits into from
Dec 21, 2016

Conversation

pinpox
Copy link

@pinpox pinpox commented Dec 9, 2016

This implements the changes as discussed in issue #8

@codecov-io
Copy link

codecov-io commented Dec 9, 2016

Current coverage is 99.09% (diff: 89.47%)

Merging #10 into master will decrease coverage by 0.11%

@@             master        #10   diff @@
==========================================
  Files            10         10          
  Lines          1649       1663    +14   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits           1636       1648    +12   
- Misses           13         15     +2   
  Partials          0          0          

Powered by Codecov. Last update 5f56bd5...c02445c

@Kunde21 Kunde21 changed the base branch from master to nDim-combine December 21, 2016 19:12
@Kunde21
Copy link
Owner

Kunde21 commented Dec 21, 2016

I've moved this PR to a feature branch, so we can finish all the refactoring before merging to master.

Copy link
Owner

@Kunde21 Kunde21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Structure chage: LGTM

@Kunde21 Kunde21 merged commit 655a88e into Kunde21:nDim-combine Dec 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants