[AllBundles] URLChooser major changes #1225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You’re modifying an interface. It’s as clear as it gets a breaking change. |
sandergo90
force-pushed
the
urlchooserMultidomain
branch
from
d066627
to
e47d154
Compare
sandergo90
force-pushed
the
urlchooserMultidomain
branch
from
cbe03b2
to
490f981
Compare
|
Can you rebase? |
Move to nodebundle Check if multidomain site Set correct values Move twig extensions Twig functions Add helpers Move url replace controller Host id Rewrite URLChooserType Pass correct hosts Change url chooser Changes Change default pageparts Add replace Url filter to page part generation Add replace url filter to text types Upgrade guide Set default label Add url tokens to media url chooser Add two route collections Move upgrade guide
sandergo90
force-pushed
the
urlchooserMultidomain
branch
from
681b882
to
353e9f1
Compare
sandergo90
changed the title
|
@jockri done |
| @@ -57,6 +56,12 @@ services: | |||
| tags: | |||
| - { name: 'twig.extension' } | |||
|
|
|||
| kunstmaan_admin.multidomain.twig.extension: | |||
There was a problem hiding this comment.
Better to place this in MultiDomainBundle?
There was a problem hiding this comment.
We can not put this in the MultiDomainBundle because the twig function needs to be available also when the MultiDomainBundle is not enabled.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
URL Chooser
The URLChooserType had been rewritten.
You now have the option to add the following type of links:
We have added this rewrite especially for the MultiDomainBundle but it's completely integrated in the KunstmaanBundlesCMS.
When you choose for an internal link type, you will need to choose a link in the menu tree. On a multidomain website, you can switch you're domain on the right site of the URL chooser.
When clicking a node in the left node tree, a token is generated and saved for the URL.
For example: in a single domain website
Selecting the node in the tree with node translation id 50, will generate a token like "[NT50]".
For example: in a multi domain website
Selecting the node in the tree with node translation id 50, on domain "my_domain_en" will generate a token like "[my_domain_en:NT50]".
MAJOR CHANGE
For the new URL chooser to work, we have added a new twig filter "replace_url". This filter needs to be used to generate the correct url automatically.
When creating a new pagePart with an url field, the twig filter is automatically being added.
On all the exiting pageParts with an URLChooser field, you need to change the twig files of the pagePart and pipe all URL's to the replace_url filter.
When adding a rich text field or a wysiwyg field, you will need to pipe the output of this field also to the replace_url filter. Hereby, all URL's chosen in the wysiwyg will also be replaced correctly.