Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid switching away from Magikeyboard without user interaction #1351

Closed
anon8675309 opened this issue Jun 7, 2022 · 5 comments
Closed

Avoid switching away from Magikeyboard without user interaction #1351

anon8675309 opened this issue Jun 7, 2022 · 5 comments

Comments

@anon8675309
Copy link

This ticket is to only switch from the Magikeyboard to the previous one when a user clicks in a text box such as the search box. The goal is to avoid having to switch to the magikeyboard twice to enter a single password.

The use case is selecting a password entry from Magikeyboard.

Current workflow (without search):

  1. In another app, switch to Magikeyboard
  2. Tap the lock icon in Magikeyboard
  3. KeePassDX opens
  4. Search text input field is selected (at least, this is true if there are multiple entries for that app) and keyboard switches to the previous keyboard
  5. Entry is selected and user is returned to the previous app
  6. Keyboard is still set to the previous keyboard (i.e. not Magikeyboard)

Describe the solution you'd like
Desired flows are as follows:

Without search:

  1. In another app, switch to Magikeyboard
  2. Tap the lock icon in Magikeyboard
  3. KeePassDX opens
  4. Entry is selected and user is returned to the previous app
  5. Keyboard is still set to Magikeyboard

With search:

  1. In another app, switch to Magikeyboard
  2. Tap the lock icon in Magikeyboard
  3. KeePassDX opens
  4. Click in the search text input field
  5. Keyboard switches to the previous keyboard so the user can type in search terms
  6. Entry is selected and user is returned to the previous app
  7. Keyboard is still set to the previous keyboard (i.e. not Magikeyboard) Note: the desired behavior for this last step may be changed by Improve keyboard switch #311, for users who grant the required permission

Describe alternatives you've considered
Long tap on the lick icon of Magikeyboard to avoid having the search text input box selected, and thus avoiding the undesired switch away from the Magikeyboard. This workaround is effective, but being able to tap (instead if long tap) and having a filtered view would be preferable. I consider this more of a feature than a bug, as it is just an improvement, not really an error.

Additional context
This ticket came about from a conversation on #311.

@TippyLion28
Copy link

I would also be interested in a solution to this, or at least a toggle to disable search as the default selection screen.

@moya2162
Copy link

Commenting to state i too am interested in a solution to this. The flow as described by anon is what I would expect as well.

@J-Jamet J-Jamet added this to the Magikeyboard milestone Jan 13, 2023
@J-Jamet J-Jamet added this to To do in 4.0.0 via automation Jul 28, 2023
@J-Jamet J-Jamet moved this from To do to In progress in 4.0.0 Jul 28, 2023
@J-Jamet J-Jamet moved this from In progress to Done in 4.0.0 Jul 28, 2023
@J-Jamet
Copy link
Member

J-Jamet commented Jul 28, 2023

I've added a condition that allows the searchView not to be focused if it's an auto search. This means that the keyboard can only be changed if the field is focused.

@anon8675309
Copy link
Author

Thanks, I'm looking forward to it. Donation is on the way. :-)

@J-Jamet
Copy link
Member

J-Jamet commented Jul 29, 2023

Appreciated

@J-Jamet J-Jamet closed this as completed Sep 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
4.0.0
Done
Development

No branches or pull requests

4 participants