-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐳💚📝 Add docker CI and update links #216
Conversation
- 📝 Update databases links fixes #175 - 🐳 Add docker.yml to .github/workflows - 🎨 Update jason-c-kwan username to jasonkwan
Can you add your credentials to the Autometa repo to finish setting up the docker CI/CD workflow? To setup, pass in your credentials in to GitHub secrets so they may be used to login to DockerHub https://github.com/KwanLab/Autometa/settings/secrets/actions To fill in:
|
- bacteria single-copy-markers cutoffs - `link <https://raw.githubusercontent.com/WiscEvan/Autometa/dev/databases/markers/bacteria.single_copy.cutoffs?token=AGF3KQVL3J4STDT4TJQVDBS6GG5FE>`__ | ||
- archaea single-copy-markers - `link <https://github.com/WiscEvan/Autometa/raw/dev/databases/markers/archaea.single_copy.hmm>`__ | ||
- archaea single-copy-markers cutoffs - `link <https://raw.githubusercontent.com/WiscEvan/Autometa/dev/databases/markers/archaea.single_copy.cutoffs?token=AGF3KQXVUDFIH6ECVTYMZQS6GG5KO>`__ | ||
- bacteria single-copy-markers - `link <https://raw.githubusercontent.com/KwanLab/Autometa/dev/autometa/databases/markers/bacteria.single_copy.hmm>`__ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would go ahead and change dev
to main
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This may be a larger issue that needs to be addressed in the docs (cc @Sidduppal )
Once dev is merged into main, dev docs will contain main
anyways
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll change these paths when merging dev
into main
. In the mean time, I do not want to provide broken links, as it seems others are currently attempting to run Autometa from the dev
branch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If there's not an issue for that already it might be worth creating one as a reminder
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, that works. There will be a number of merge conflicts to address during that merge, so I was thinking that would be a sufficient reminder to double check dev
being changed to main
in all files. Either works 🤷
…flow 🐳💚 Swap extract branch names for docker metadata-action (https://github.com/docker/metadata-action) :green_heart::art: Add logic to only push docker image if the commit was pushed to the branh (not a PR)
docker.yml
to.github/workflows
- fixes Create GitHub Action for building and publishing docker images #191jason-c-kwan
username tojasonkwan