Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make cross margin unavailable in prod mode #1243

Merged
merged 1 commit into from
Aug 8, 2022
Merged

Conversation

avclarke
Copy link
Contributor

@avclarke avclarke commented Aug 8, 2022

The previous method to only disable the toggle didn't cover all bases of disabling cross margin in prod.

@vercel
Copy link

vercel bot commented Aug 8, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
kwenta ✅ Ready (Inspect) Visit Preview Aug 8, 2022 at 10:06AM (UTC)

@avclarke avclarke requested a review from platschi August 8, 2022 10:03
@vercel vercel bot temporarily deployed to Preview August 8, 2022 10:06 Inactive
@platschi platschi requested a review from LeifuChen August 8, 2022 12:13
@platschi platschi merged commit 55c2599 into dev Aug 8, 2022
@platschi platschi deleted the fix/disable-cross-margin branch August 8, 2022 13:33
@KngZhi KngZhi mentioned this pull request Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants