Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove arrow indicator for funding #1223 #1246

Merged
merged 6 commits into from
Aug 9, 2022

Conversation

hruday11
Copy link
Contributor

@hruday11 hruday11 commented Aug 8, 2022

Removed arrow indicator from 1H funding in FuturesMarketTable

Description

removed arrow from 1H funding by providing sortable as false

Related issue

https://github.com/Kwenta/kwenta-private/issues/552

How Has This Been Tested?

Tested on local

Screenshots (if appropriate):

Screenshot 2022-08-09 at 12 14 02 AM

@vercel
Copy link

vercel bot commented Aug 8, 2022

@hruday11 is attempting to deploy a commit to the Kwenta Team on Vercel.

A member of the Team first needs to authorize it.

@platschi platschi self-requested a review August 8, 2022 18:46
@vercel
Copy link

vercel bot commented Aug 8, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
kwenta ✅ Ready (Inspect) Visit Preview Aug 9, 2022 at 5:55PM (UTC)

@vercel vercel bot temporarily deployed to Preview August 8, 2022 19:15 Inactive
@vercel vercel bot temporarily deployed to Preview August 8, 2022 22:43 Inactive
@vercel vercel bot temporarily deployed to Preview August 9, 2022 16:52 Inactive
@vercel vercel bot temporarily deployed to Preview August 9, 2022 17:55 Inactive
@platschi platschi requested a review from Tburm August 9, 2022 19:27
Copy link
Contributor

@platschi platschi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, deploy tested on mobile and desktop, both now show 1H Funding without the green/red arrows.

@platschi platschi merged commit 2a8358b into Kwenta:dev Aug 9, 2022
@KngZhi KngZhi mentioned this pull request Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants