Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve skew component #1321

Merged
merged 10 commits into from
Aug 24, 2022
Merged

Conversation

Xiaolei-Shawn
Copy link
Contributor

Description

  • Remove numbers under skew bar and show them as tooltip on OI percentages
  • Change height of table body row to 55px for trade history and futures market tables

Related issue

https://github.com/Kwenta/kwenta-private/issues/544

Motivation and Context

Align to design

How Has This Been Tested?

Screenshots (if appropriate):

Screenshot 2022-08-23 at 22 53 00

Screenshot 2022-08-23 at 22 52 44

@vercel
Copy link

vercel bot commented Aug 23, 2022

@Xiaolei-Shawn is attempting to deploy a commit to the Kwenta Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link

vercel bot commented Aug 23, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
kwenta ✅ Ready (Inspect) Visit Preview Aug 24, 2022 at 9:34PM (UTC)

@vercel vercel bot temporarily deployed to Preview August 23, 2022 22:43 Inactive
@platschi platschi self-requested a review August 24, 2022 00:09
@vercel vercel bot temporarily deployed to Preview August 24, 2022 13:55 Inactive
@vercel vercel bot temporarily deployed to Preview August 24, 2022 18:58 Inactive
@platschi platschi requested a review from Tburm August 24, 2022 19:10
platschi
platschi previously approved these changes Aug 24, 2022
Copy link
Contributor

@platschi platschi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, design and functionality as expected 👍🏼

Copy link
Contributor

@Tburm Tburm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one thing to fix on centering table rows

sections/futures/TradingHistory/TradesHistoryTable.tsx Outdated Show resolved Hide resolved
@vercel vercel bot temporarily deployed to Preview August 24, 2022 21:19 Inactive
@vercel vercel bot temporarily deployed to Preview August 24, 2022 21:26 Inactive
@vercel vercel bot temporarily deployed to Preview August 24, 2022 21:34 Inactive
Copy link
Contributor

@Tburm Tburm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Xiaolei-Shawn sorry I blew up this PR but I fixed the thing I wanted to fix

@platschi platschi merged commit d6d1af3 into Kwenta:dev Aug 24, 2022
@KngZhi KngZhi mentioned this pull request Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants