Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve trade preview speed #1494

Merged
merged 1 commit into from
Oct 21, 2022
Merged

Improve trade preview speed #1494

merged 1 commit into from
Oct 21, 2022

Conversation

avclarke
Copy link
Contributor

Batches some smart contract calls together before calculating the preview

@vercel
Copy link

vercel bot commented Oct 20, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
kwenta ✅ Ready (Inspect) Visit Preview Oct 21, 2022 at 6:29AM (UTC)

@vercel vercel bot temporarily deployed to Preview October 20, 2022 21:02 Inactive
@vercel vercel bot temporarily deployed to Preview October 21, 2022 06:29 Inactive
@platschi platschi marked this pull request as ready for review October 21, 2022 14:17
Copy link
Contributor

@platschi platschi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works better now, preview delay lowered from 5-6 seconds to ~2 seconds here 👍🏼

Copy link
Contributor

@Tburm Tburm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, it feels much faster and makes a lot of sense to fetch everything at once 👍

@platschi platschi merged commit 55b8069 into dev Oct 21, 2022
@platschi platschi deleted the cm-trade-preview branch March 22, 2023 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants