Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Responsive Price Displays #1826

Merged
merged 6 commits into from
Jan 5, 2023
Merged

Responsive Price Displays #1826

merged 6 commits into from
Jan 5, 2023

Conversation

Tburm
Copy link
Contributor

@Tburm Tburm commented Jan 3, 2023

Correct some price displays and make them responsive to offchain price updates.

Description

  • Update position selectors to recalculate unrealized pnl from the skew adjusted price
  • Update header price to display skew adjusted price

@vercel
Copy link

vercel bot commented Jan 3, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
kwenta ✅ Ready (Inspect) Visit Preview Jan 5, 2023 at 6:56PM (UTC)

@Tburm Tburm changed the title Responsive Price Responsive Price Displays Jan 3, 2023
@Tburm Tburm requested a review from avclarke January 3, 2023 22:31
Copy link
Contributor

@avclarke avclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just think it would be good to extract that duplicated selector logic

state/futures/selectors.ts Outdated Show resolved Hide resolved
@vercel vercel bot temporarily deployed to Preview January 4, 2023 19:45 Inactive
@vercel vercel bot temporarily deployed to Preview January 5, 2023 18:56 Inactive
@Tburm Tburm requested a review from avclarke January 5, 2023 18:57
@Tburm Tburm merged commit 25d003d into perps-v2-dev Jan 5, 2023
@Tburm Tburm deleted the responsive-price branch January 5, 2023 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants