Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update eth deposit messaging and fix a test #2743

Merged
merged 1 commit into from
Aug 4, 2023
Merged

Conversation

avclarke
Copy link
Contributor

@avclarke avclarke commented Aug 3, 2023

Description

  • Updates the messaging for ETH conditional order deposit and fixes number formatting of large numbers.
  • Fixes a broken test

@vercel
Copy link

vercel bot commented Aug 3, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
kwenta ✅ Ready (Inspect) Visit Preview Aug 3, 2023 10:04pm
kwenta-storybook ✅ Ready (Inspect) Visit Preview Aug 3, 2023 10:04pm

@codecov
Copy link

codecov bot commented Aug 3, 2023

Codecov Report

Merging #2743 (b616397) into dev (bfc59bd) will increase coverage by 1.41%.
Report is 41 commits behind head on dev.
The diff coverage is 52.94%.

@@            Coverage Diff             @@
##              dev    #2743      +/-   ##
==========================================
+ Coverage   51.27%   52.68%   +1.41%     
==========================================
  Files         382      392      +10     
  Lines       11540    12432     +892     
  Branches     2757     2861     +104     
==========================================
+ Hits         5917     6550     +633     
- Misses       5400     5653     +253     
- Partials      223      229       +6     
Files Changed Coverage Δ
packages/app/src/components/TVChart/DataFeed.ts 21.79% <ø> (+3.04%) ⬆️
packages/app/src/constants/links.ts 66.66% <ø> (ø)
...es/app/src/sections/futures/MarketDetails/utils.ts 100.00% <ø> (ø)
...app/src/sections/futures/ShareModal/ShareModal.tsx 76.19% <ø> (ø)
...ions/futures/SmartMarginOnboard/SmartMarginFAQ.tsx 50.00% <ø> (ø)
...sections/futures/Trade/MarketsDropdownSelector.tsx 89.65% <0.00%> (ø)
...ions/futures/TradingHistory/TradesHistoryTable.tsx 45.67% <0.00%> (-0.58%) ⬇️
...p/src/sections/shared/Layout/HomeLayout/Banner.tsx 43.18% <0.00%> (+3.59%) ⬆️
packages/app/src/state/exchange/actions.ts 13.06% <0.00%> (ø)
packages/app/src/state/futures/types.ts 100.00% <ø> (ø)
... and 107 more

... and 4 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@LeifuChen LeifuChen self-requested a review August 3, 2023 22:16
Copy link
Contributor

@LeifuChen LeifuChen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix.

@platschi platschi merged commit ae7e728 into dev Aug 4, 2023
5 of 6 checks passed
@platschi platschi deleted the fix/eth-depoit-message branch August 4, 2023 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants