Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ja to null-terminate code strings. #11

Merged
merged 2 commits into from
Nov 13, 2017
Merged

Use ja to null-terminate code strings. #11

merged 2 commits into from
Nov 13, 2017

Conversation

abalkin
Copy link
Contributor

@abalkin abalkin commented Nov 11, 2017

This is an optimization that results in 30-50% speedup in micro-benchmarks.

@abalkin
Copy link
Contributor Author

abalkin commented Nov 11, 2017

@jhanna-kx - please double check the reference counting logic.

jhanna-kx
jhanna-kx approved these changes Nov 13, 2017
View reviewed changes
Copy link
Collaborator

@jhanna-kx jhanna-kx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me thanks @abalkin

@jhanna-kx jhanna-kx merged commit ac24bab into master Nov 13, 2017
@effbiae effbiae mentioned this pull request Nov 22, 2017
Closed
@jhanna-kx jhanna-kx deleted the cjoin branch August 21, 2018 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhanna-kx jhanna-kx jhanna-kx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abalkin @jhanna-kx