Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds isnull, isna, notnull, notna, idxmax, idxmin, kurt and sem functions #24

Merged
merged 6 commits into from
May 1, 2024
Merged

Adds isnull, isna, notnull, notna, idxmax, idxmin, kurt and sem functions #24

merged 6 commits into from
May 1, 2024

Conversation

nipsn
Copy link
Contributor

@nipsn nipsn commented Feb 13, 2024

Feature

What does this change introduce?

An implementation of the isnull, isna, notnull and notna functions:

An implementation of the idxmax and idxmin functions:

An implementation of kurt:
https://pandas.pydata.org/pandas-docs/stable/reference/api/pandas.DataFrame.kurt.html

An implementation of sem:
https://pandas.pydata.org/pandas-docs/stable/reference/api/pandas.DataFrame.sem.html

General

  • Has an example been added to demo the new feature?
  • Have existing examples been updated or tested?
  • Have you added any new Environment Variables/Configuration Options? If yes please tick the boxes below as applicable
    • Addition to reimporter logic within src/pykx/pykx.q and src/pykx/reimporter.py
    • Have updated the src/pykx/util.py logic which is used for environment variable
  • If there have been any dependency updates have they been reflected in all files?
    • pyproject.toml
    • docs/getting-started/installing.md
    • conda-recipe/meta.yaml
    • README.md
  • If any examples have been updated has it's associated .zip been updated

Code

  • Has all temporary code used during development been removed?
  • Has all commented out (unused) code been removed?
  • Where reasonable have you ensured there is no duplication of existing code?
  • If applicable for your use-case have you ensured that the code is performant?

Testing

  • Have unit tests been created or existing ones updated to test this new functionality?

Documentation

  • Has documentation been added for all public code?
  • Has a release note been included for the new feature?
  • Has any documentation which would benefit from this feature been updated to use the most up to date functionality?
  • If a new class has been added has a documentation stub .md file associated with it been created?
  • If any documentation page has been created has it been added to mkdocs.yml
  • Have you checked your changes with a spell checker? (US English)

nipsn and others added 6 commits February 9, 2024 14:30
@nipsn
Added null check methods (#27)
460a218 
* Added initial isnull isna and notna implementations and tests

* Proper alias, added tests and documentation

* Reworked tests and added notnull method
@nipsn @tortolavivo23
Add kurt and sem functions (#32)
bb1549a 
* Added implementation of kurt function (#23)

* Added implementation of sem function (#22)

* Refactored kurt and sem functions

---------

Co-authored-by: Miguel Gómez <miguel.gomez@hablapps.com>
Co-authored-by: Francisco Tórtola Vivo <francisco.tortola@hablapps.com>
@nipsn
Added idxmin implementation (#34)
7ef4142
@tortolavivo23 @neutropolis
Added idxmax implementation (#25)
4f59edd 
* Added idxmax implementation, tests and documentation

* fix error change python version in documentation

* Change implementation, add tests and improve documentation

* fix typo error

* Alternative implementation of idxmax (#33)

Co-authored-by: Jesús López-González <jesus.lopez@habla.dev>

---------

Co-authored-by: Jesús López-González <github.bogus571@passmail.net>
Co-authored-by: Jesús López-González <jesus.lopez@habla.dev>
Co-authored-by: Jesús López-González <jesus.lopez.gonzalez+dev@pm.me>
Merge branch 'main' into feature/pandas-api-2nd-block-extra
f51a061
@nipsn
Reordered nb documentation
0019cab
@github-actions github-actions bot added documentation Improvements or additions to documentation python tests labels Feb 13, 2024
@nipsn
Copy link
Contributor Author

nipsn commented Feb 13, 2024

@cmccarthy1 @rianoc-kx
Please review our contributions and feel free to give any kind of feedback.
Thanks in advance.

@cmccarthy1
Copy link
Collaborator

@nipsn taking a look at this now, will see if we can get it merged for our 2.4 release next week but suspect it may be 2.5 for these additions

@rianoc-kx rianoc-kx changed the base branch from main to KXI-43682 May 1, 2024 12:27
@rianoc-kx rianoc-kx merged commit 79c30fc into KxSystems:KXI-43682 May 1, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation python tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nipsn @cmccarthy1 @rianoc-kx @tortolavivo23