Add missing default arguments for AsyncIOMotorClient
#1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds default arguments for the following member functions of `AsyncIOMotorClient`: * `get_database`, * `get_default_database`, * `list_databases` and * `start_session` The original source code containing these defaults can be found at [pymongo/mongo_client.py](https://github.com/mongodb/mongo-python-driver/blob/master/pymongo/mongo_client.py).
|
I apologise for the late reply, I'll check the PR and get back to you shortly. Thanks for your contribution! |
L0RD-ZER0
approved these changes
Feb 12, 2023
L0RD-ZER0
added a commit
that referenced
this pull request
Feb 12, 2023
Added missing optional arguments' default values as indicated in #1.
|
As of 2491fa8, there shouldn't be any other missing optional type-hints. The package on PyPI has been updated and changes should reflect on update. Once again, thanks for finding this one out! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
this commit adds default arguments for the following member functions of
AsyncIOMotorClient:get_database,get_default_database,list_databasesandstart_sessionThe original source code containing these defaults can be found at pymongo/mongo_client.py.