Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Factor out the dashboard page layout into a shared layout #432

Closed
5 tasks
fozziethebeat opened this issue Jan 6, 2023 · 3 comments
Closed
5 tasks

Factor out the dashboard page layout into a shared layout #432

fozziethebeat opened this issue Jan 6, 2023 · 3 comments
Assignees
Labels
UI/UX All website Components website

Comments

@fozziethebeat
Copy link
Collaborator

Right now website/src/pages/dashboard includes a nice Sidebar with multiple menu options and then presents the select page's contents.

This is a great design that would be nice to use in other scenarios such as for an admin specific page which would have different sidebar options.

To do this I think we need to:

  • Make website/src/components/Dashboard/SideMenu it's own independent component that takes in a list of menu options as a property.
  • Factor out the layout code in website/src/pages/dashboard into a layout component in website/src/components/SideMenuLayout that also takes in the list of menu options.
  • Create several concrete layouts: GeneralSidebarLayout and AdminSidebarLayout, and maybe others.
  • Use GeneralSidebarLayout in website/src/pages/dashboard
  • Use AdminSidebarLayout in future admin pages but using a different color scheme and different sidebar options.
@fozziethebeat fozziethebeat added website UI/UX All website Components labels Jan 6, 2023
@Klotske
Copy link
Contributor

Klotske commented Jan 6, 2023

@fozziethebeat I think I could take this issue. Could you assign it to me?
Self-assigning needs Github's Collaborator role i think...

@fozziethebeat
Copy link
Collaborator Author

Great!@ Yeah, the assigning part is a bit of a hassle. After the MVP we might want to have a group discussion about simplifying it.

Also, since this is quite a few changes, I'd request this be done in a couple PRs rather than one giant PR.

AbdBarho added a commit that referenced this issue Jan 7, 2023
#432 - Moved SideMenu to component & refactored layout
fozziethebeat added a commit that referenced this issue Jan 8, 2023
@AbdBarho
Copy link
Collaborator

AbdBarho commented Jan 8, 2023

could this be closed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
UI/UX All website Components website
Projects
None yet
Development

No branches or pull requests

3 participants