Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#432 - Moved SideMenu to component & refactored layout #469

Merged
merged 2 commits into from
Jan 7, 2023

Conversation

Klotske
Copy link
Contributor

@Klotske Klotske commented Jan 7, 2023

#432
Should complete tasks 1 & 2. Moved the SideMenu to it's own component & included it in the SideMenuLayout.
Updated getDashboardLayout in NextJS's Layout resolver to work with new component.
Reworked /dashboard and '/messages' pages to use the updated getDashboardLayout.

Also spotted wierd issue with colorMode flashing while switching between /dashboard and /messages. Might look into it a little bit later.

Copy link
Collaborator

@AbdBarho AbdBarho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good!

@AbdBarho AbdBarho merged commit f2d8054 into LAION-AI:main Jan 7, 2023
@Klotske Klotske deleted the separate-dashboard-layout branch January 7, 2023 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants