#432 - Added basic Admin Dashboard layout #480
Conversation
Klotske
requested review from
fozziethebeat,
k-nearest-neighbor and
AbdBarho
as code owners
| icon: FiUsers, | ||
| }, | ||
| ]} | ||
| > |
There was a problem hiding this comment.
I think the admin should also be able to see the dashboard & messages, at least for development purposes.
There was a problem hiding this comment.
I can add the links as in the original dashboard layout
But this would present another problem. Now we are not providing layout based on the user's role. It's basically a whole another layout component for /admin route.
So when admin user interacts with these links to /dashboard and /messages sidebar won't include admin's menu options.
There was a problem hiding this comment.
ah, I see.. that is actually a problem.
would it make sense to add the items in the original dashboard if the user is admin?
There was a problem hiding this comment.
I think it would be reasonable. But need some comments from @fozziethebeat as the original issue mentioned separate layouts.
There was a problem hiding this comment.
In my mind the admin page would be a separate view that's accessible from the user drop down in the header. It would have the same look and feel of the contributing dashboard but with different side menu options.
That way, its clearly a different mode of interaction. This is why I was thinking we'd use the same set of generic components but fill them independently.
This PR matches what I was requesting.
There was a problem hiding this comment.
I'm going to merge this since it matched the design I had in mind (but maybe didnt' explain super clearly). Let's discuss this in the next live call to see how we might want to change the design.
#432
Should be done with the issue. For now decided against moving
GeneralSidebarLayoutandAdminSidebarLayoutinto separate components. But that could easily be fixed.Fixed
/adminpage to use newgetAdminLayoutfunction.Preview:
