Implement *_reply for the web
#81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbdBarho
requested review from
fozziethebeat and
k-nearest-neighbor
as code owners
fozziethebeat
approved these changes
Dec 27, 2022
Also, start extracting shared components
|
|
||
| const getColor = (isAssistant: boolean) => (isAssistant ? "slate-800" : "sky-900"); | ||
|
|
||
| export const Messages = ({ messages }: { messages: Message[] }) => { |
There was a problem hiding this comment.
For a later date, this seems like a viable component for Chakra-ui style style variants. I have an example of this in a test library I made in https://github.com/SurfaceData/surface-react-components/blob/main/src/themes/surface/components/button.ts and https://github.com/SurfaceData/surface-react-components/blob/main/src/Button/Button.tsx.
This would cut down the code and let us drop the getColor method. But we can do that cleanup later.
|
Merging this now as I see changes have been made. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #30
Closes #31
I have started to consolidate some of the re-used components to make the code easier to read, I did not change files modified in #76, this could be done in another pr.
I am unsure how "clean" the code should be for the mvp, but we can always clean it up later.